Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up little things #61

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Cleaning up little things #61

merged 2 commits into from
Sep 30, 2023

Conversation

madflojo
Copy link
Member

@madflojo madflojo commented Sep 30, 2023

Summary by CodeRabbit

  • Refactor: Updated the tests-nobuild target in the Makefile to include two new Docker containers (consul and consulator) for enhanced testing environment.
  • Documentation: Removed the "globals" object from the tarmac.json file, specifically the "log_level" property. This change simplifies the configuration process.
  • Chore: Modified the CI/CD pipeline's "Execute Tests" step to replace make build tests-nodeps with make build tests-base, improving the build and test process by using a different set of dependencies or configurations.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2023

Walkthrough

This update modifies the testing environment setup in the Makefile, adjusts the logging configuration in tarmac.json, and alters the build and test process in the CI/CD pipeline.

Changes

File Summary
Makefile Added two Docker containers (consul and consulator) to be launched before running tests.
docs/wasm.../multi-function-services.md Removed the global log level configuration from tarmac.json.
.github/workflows/build.yml Replaced make build tests-nodeps with make build tests-base in the "Execute Tests" step of the CI/CD pipeline.

🐇💻

In the land of code, changes are afoot,

Docker containers launch, no dispute.

Logging levels gone, silence is moot,

And the pipeline's tune plays a different flute.

Celebrate these changes, they're astute! 🎉🥕


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 8a3f1d1 and 1b0b34e.
Files ignored due to filter (2)
  • dev-compose.yml
  • testdata/tarmac-consul.yml
Files selected for processing (2)
  • Makefile (1 hunks)
  • docs/wasm-functions/multi-function-services.md (1 hunks)
Files skipped from review due to trivial changes (2)
  • Makefile
  • docs/wasm-functions/multi-function-services.md

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #61 (0253699) into main (8a3f1d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files          12       12           
  Lines        1125     1125           
=======================================
  Hits          927      927           
  Misses        152      152           
  Partials       46       46           

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 1b0b34e and 0253699.
Files selected for processing (1)
  • .github/workflows/build.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/build.yml

@madflojo madflojo merged commit addf194 into main Sep 30, 2023
11 checks passed
@madflojo madflojo deleted the globalsconfig branch September 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant